netdev - Re: [PATCH 00/11] DMA sync errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100120.161805.118613816.davem@davemloft.net>
Date:	Wed, 20 Jan 2010 16:18:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	jarkao2@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 00/11] DMA sync errors

From: Stephen Hemminger <shemminger@...tta.com>
Date: Wed, 20 Jan 2010 15:28:32 -0800

> This should fix the dma-debug API code (and documentation), to
> avoid false positives when sync is done on a partial map.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
 ...
> --- a/lib/dma-debug.c	2010-01-20 15:22:55.919519883 -0800
> +++ b/lib/dma-debug.c	2010-01-20 15:26:31.648895638 -0800
> @@ -285,11 +285,9 @@ static struct dma_debug_entry *hash_buck
>  	}
>  
>  	/*
> -	 * If we have multiple matches but no perfect-fit, just return
> -	 * NULL.
> +	 * If we have multiple matches but no perfect-fit
> +	 * return best value and let caller deal with it.
>  	 */
> -	ret = (matches == 1) ? ret : NULL;
> -
>  	return ret;
>  }
>  

I think you have to enforce a perfect-fit match for the
non-SYNC cases.

check_sync() can pass in 'true' for a new bool argument "partial_ok"
added to hash_bucket_find() whereas check_unmap() can pass 'false'.

get_nr_mapped_entries() should pass 'false' as well.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html