netdev - Re: [PATCH v5] rps: Receive Packet Steering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B581B65.7070109@gmail.com>
Date:	Thu, 21 Jan 2010 10:16:21 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Changli Gao <xiaosuo@...il.com>
CC:	Tom Herbert <therbert@...gle.com>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH v5] rps: Receive Packet Steering

Le 21/01/2010 08:54, Changli Gao a écrit :
> Sometimes, rxhash will be 0 generated. In order to check whether
> rxhash is generated or not, a new bit field in sk_buff is needed. When
> rxhash is generated and saved in sk_buff, the bit is set.
> 
> And, I think rxhash should be reserved when calling skb_copy and skb_clone.
> 
> 

I disagree

A null rxhash should not be generated by a driver, or even if its null,
why should we care ?

In this very unlikely event, let get_rps_cpu() compute a (non null) hash.

Adding a bit in skb for such low probability event brings nothing but complexity.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html