netdev - Re: [PATCH 4/9] net/sctp: Eliminate useless code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Jan 2010 02:43:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	julia@...u.dk
Cc:	vladislav.yasevich@...com, sri@...ibm.com,
	linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 4/9] net/sctp: Eliminate useless code

From: Julia Lawall <julia@...u.dk>
Date: Thu, 21 Jan 2010 11:22:38 +0100 (CET)

> On Wed, 20 Jan 2010, David Miller wrote:
> 
>> From: Vlad Yasevich <vladislav.yasevich@...com>
>> Date: Wed, 20 Jan 2010 13:10:10 -0500
>> 
>> > 
>> > 
>> > Julia Lawall wrote:
>> >> From: Julia Lawall <julia@...u.dk>
>> >> 
>> >> The variable newinet is initialized twice to the same (side effect-free)
>> >> expression.  Drop one initialization.
>> >> 
>> >> A simplified version of the semantic match that finds this problem is:
>> >> (http://coccinelle.lip6.fr/)
>> >> 
>> >> // <smpl>
>> >> @forall@
>> >> idexpression *x;
>> >> identifier f!=ERR_PTR;
>> >> @@
>> >> 
>> >> x = f(...)
>> >> ... when != x
>> >> (
>> >> x = f(...,<+...x...+>,...)
>> >> |
>> >> * x = f(...)
>> >> )
>> >> // </smpl>
>> >> 
>> >> Signed-off-by: Julia Lawall <julia@...u.dk>
>> > 
>> > Acked-by: Vlad Yasevich <vladislav.yasevich@...com>
>> 
>> Julia,  just like patch #3 this one had the missing final
>> line of the patch corrupting it, so you'll need to resubmit.
> 
> I have generated and sent it again, but this time I don't see the problem.  
> If there is still a problem, perhaps you could send me back the patch you 
> received?

You dropped Vlad' ACK in your re-submission.

I'll fix it up this time, but please accumulate ACK's when
resubmitting patches merely for the purpose of fixing some
technical submission problem.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html