lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Jan 2010 22:25:01 -0800 From: Joe Perches <joe@...ches.com> To: Taku Izumi <izumi.taku@...fujitsu.com> Cc: netdev@...r.kernel.org, Bruce Allan <bruce.w.allan@...el.com>, "David S. Miller" <davem@...emloft.net>, Jesse Brandeburg <jesse.brandeburg@...el.com>, John Ronciak <john.ronciak@...el.com>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>, Koki Sanagi <sanagi.koki@...fujitsu.com>, Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>, chavey@...gle.com Subject: Re: [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters Trivial: All of the printks without KERN_<level> should be KERN_CONT For example: > + printk(KERN_ERR "%-15s ", rname); > + for (n = 0; n < 2; n++) > + printk("%08x ", __er32(hw, get_regofs(n))); > + printk("\n"); This should be: printk(KERN_ERR etc...) for (n = 0...) printk(KERN_CONT "%08x ", etc... printk(KERN_CONT "\n") or perhaps written without the for loop printk(KERN_ERR "%-15s %08x %08x\n", name, __er32(hw, get_regofs(0)), __er32(hw, get_regofs(1))); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists