netdev - RE: [PATCH net-next-2.6 13/13] net-caif-driver: add CAIF serial driver (ldisc)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61D8D34BB13CFE408D154529C120E07903232089@eseldmw101.eemea.ericsson.se>
Date:	Fri, 22 Jan 2010 10:56:20 +0100
From:	Sjur Brændeland <sjur.brandeland@...ricsson.com>
To:	"Marcel Holtmann" <marcel@...tmann.org>
Cc:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<stefano.babic@...ic.homelinux.org>, <randy.dunlap@...cle.com>
Subject: RE: [PATCH net-next-2.6 13/13] net-caif-driver: add CAIF serial driver (ldisc)

Marcel Holtmann wrote:
> Hi Sjur,
> 
>> Add CAIF Serial driver. This driver is implemented as a line
>> discipline. The TTY is opened from inside the kernel module.
>> 
>> caif_serial uses the following module parameters:
>> ser_ttyname - specifies the tty name.
>> ser_use_stx - specifies if STart of frame eXtension is in use.
>> ser_loop    - sets the interface in loopback mode.
> 
> I think opening the TTY from within the kernel is the wrong approach.
> It basically takes all the control away from the system people trying
> to bring up the device. And for every special TTY you need to add
> hacks and workarounds.   
> 
> You should be just providing the TTY line discipline for CAIF. And
> then have a program like caifattach that open the TTY and sets it. We
> do this for Bluetooth with hciattach for IrDA with irattach etc.  

I see your point, actually we did this in a while back, 
but changed it to open the tty from kernel side.
I think this is a trade off between flexibility and making it simple to 
use from user space. Another problem with the current approach miss the
flexibility of configuring the UART and the possibility to have multiple 
serial links...

BR/Sjur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html