netdev - Re: [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.WNT.2.00.1001221345580.6104@jbrandeb-desk1.amr.corp.intel.com>
Date:	Fri, 22 Jan 2010 13:54:11 -0800 (Pacific Standard Time)
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	Taku Izumi <izumi.taku@...fujitsu.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	Koki Sanagi <sanagi.koki@...fujitsu.com>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	"chavey@...gle.com" <chavey@...gle.com>,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout
 code just before resetting adapters

On Thu, 21 Jan 2010, Taku Izumi wrote:
> This patchset is the update version of "register etc. printout code" patch. (sorry
> for late reply)
> The old one is http://marc.info/?l=linux-netdev&m=126286127208276&w=2
> 
> v1 -> v2:
>  - replaced hexdump() with print_hex_dump()
>  - changed the register printout inplementation (for-switch-case -> data-driven-table)
> 
> However the default value of "dump_flag" is not changed (still 1).
> The reason I didn't change is
>  - I think HW index (TDH,TDT..) and SW index (NTC,NTU) are at least necessary
>  - the amount of default output is not so large (see bellow)
>  - the adapter resetting problem doesn't happen frequently

Taku, thanks for these, we are talking the patches over and reviewing 
them.  While I agree with the idea of these patches is good, I still don't 
agree with the default being enabled.  Usually if someone is getting tx 
hangs they are repeatable and we can work with them to get the debug 
turned on.  I DO think it is useful to have the feature available by 
default but NOT enabled.

If we wanted to enable something by default it might be useful to print 
something that actually draws some conclusions from known failure modes, 
like if TDH!=TDT after some amount of time.  I think one or two lines 
maximum for default printing.

If you're working in this area I had an idea.  I had wanted to be able to 
print the large amount of ring information (especially in the ixgbe case 
with many rings) to the ftrace buffers in order to not overrun the syslog 
daemon.  Not sure if you're interested in more new features, it certainly 
is separate but related to this patch. 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html