netdev - Re: [net-2.6 PATCH] e1000/e1000e: don't use small hardware rx buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100123.010756.67415950.davem@davemloft.net>
Date:	Sat, 23 Jan 2010 01:07:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	jesse.brandeburg@...el.com
Subject: Re: [net-2.6 PATCH] e1000/e1000e: don't use small hardware rx
 buffers

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Sat, 23 Jan 2010 00:56:16 -0800

> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> When testing the "e1000: enhance frame fragment detection" (and e1000e)
> patches we found some bugs with reducing the MTU size.  The 1024 byte
> descriptor used with the 1000 mtu test also (re) introduced the
> (originally) reported bug, and causes us to need the e1000_clean_tx_irq
> "enhance frame fragment detection" fix.
> 
> So what has occured here is that 2.6.32 is only vulnerable for mtu <
> 1500 due to the jumbo specific routines in both e1000 and e1000e.
> So, 2.6.32 needs the 2kB buffer len fix for those smaller MTUs, but
> is not vulnerable to the original issue reported.  It has been pointed
> out that this vulnerability needs to be patched in older kernels that
> don't have the e1000 jumbo routine.  Without the jumbo routines, we
> need the "enhance frame fragment detection" fix the e1000, old
> e1000e is only vulnerable for < 1500 mtu, and needs a similar
> fix.  We split the patches up to provide easy backport paths.
> 
> There is only a slight bit of extra code when this fix and the
> original "enhance frame fragment detection" fixes are applied, so
> please apply both, even though it is a bit of overkill.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html