netdev - Re: [PATCH 1/1 V3] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100123.020549.147260506.davem@davemloft.net>
Date:	Sat, 23 Jan 2010 02:05:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kristoffer@...sler.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1 V3] net: Add Aeroflex Gaisler 10/100/1G Ethernet
 MAC driver

From: Kristoffer Glembo <kristoffer@...sler.com>
Date: Fri, 22 Jan 2010 13:51:17 +0100

> Adds device driver for Aeroflex Gaisler 10/100 and 10/100/1G Ethernet MAC IP cores.
> 
> Signed-off-by: Kristoffer Glembo <kristoffer@...sler.com>

Generates build warnings, please fix:

drivers/net/greth.c: In function ‘greth_rx’:
drivers/net/greth.c:781: warning: passing argument 1 of ‘greth_print_rx_packet’ makes integer from pointer without a cast
drivers/net/greth.c: In function ‘greth_rx_gbit’:
drivers/net/greth.c:885: warning: passing argument 1 of ‘greth_print_rx_packet’ makes integer from pointer without a cast

phys_to_virt() give a virtual address pointer, so this should
have generated warnings on 64-bit as well as 32-bit systems.

I can't see how you could have possibly build tested this and
not seen the warnings.