netdev - Re: [RFC 7/9] snet: introduce snet_netlink.c and snet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2my04d3a3.fsf@ssh.synack.fr>
Date:	Sat, 23 Jan 2010 20:33:56 +0100
From:	Samir Bellabes <sam@...ack.fr>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	linux-security-module@...r.kernel.org, jamal <hadi@...erus.ca>,
	Evgeniy Polyakov <zbr@...emap.net>,
	Neil Horman <nhorman@...driver.com>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [RFC 7/9] snet: introduce snet_netlink.c and snet_netlink.h

Patrick McHardy <kaber@...sh.net> writes:

> Samir Bellabes wrote:
>> +++ b/security/snet/include/snet_netlink.h
>> @@ -0,0 +1,201 @@
>> +#ifndef _SNET_NETLINK_H
>> +#define _SNET_NETLINK_H
>> +
>> +#include <linux/in6.h>
>> +#include "snet_hooks.h"
>> +
>> +extern unsigned int snet_verdict_delay;
>
> As this file defines the userspace interface, it probably shouldn't
> contain declarations of kernel-internal variables (same for
> snet_hooks.h). It would also be better placed in include/linux as
> the other netlink API definitions.

sorry the the delay on this.
indeed, this is fixed now, thanks Patrick

sam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html