netdev - Re: [PATCH net-next-2.6] net: use helpers to access uc list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100125121427.GB2902@psychotron.redhat.com>
Date:	Mon, 25 Jan 2010 13:14:29 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net: use helpers to access uc list

Mon, Jan 25, 2010 at 11:06:28AM CET, davem@...emloft.net wrote:
>From: Jiri Pirko <jpirko@...hat.com>
>Date: Mon, 25 Jan 2010 09:34:52 +0100
>
>> Well I use "unsigned char *" as iterator because it would allow
>> smooth thansition to list_head in case of mc_list. Currently "struct
>> dev_addr_list" is used to store address in the list but in the end
>> "struct netdev_hw_addr *" will be used.  To use "struct list_head *"
>> or "struct netdev_hw_addr *" as an iterator it would be needed to
>> convert all drivers at once and that's not doable. Therefore I see
>> "unsigned char *" cursor as the best option.
>
>But it's not what you want to use in the end, at all.
>
>If you're going to use a very ugly and opaque iterator type merely to
>ease transition, that's not a good reason.

I definitelly see your concerns. I'll think of a better way. Thanks for the
review!

Redards.

Jirka
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html