[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100125.155013.244358929.davem@davemloft.net>
Date: Mon, 25 Jan 2010 15:50:13 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: bhutchings@...arflare.com
Cc: netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 2/2] sfc: Use fixed-size buffers for MCDI NVRAM requests
From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 25 Jan 2010 19:30:52 +0000
> The low-level MCDI code always uses 32-bit MMIO operations, and
> callers must pad input and output buffers to multiples of 4 bytes.
> The MCDI NVRAM functions are not doing this. Also, their buffers are
> declared as variable-length arrays with no explicit maximum length.
>
> Switch to a fixed buffer size based on the chunk size used by the
> MTD driver (which is a multiple of 4).
>
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists