netdev - Re: [PATCH 01/25 v2] mlx4_core: identify function as pf or vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ada3a1spgu8.fsf@roland-alpha.cisco.com>
Date:	Tue, 26 Jan 2010 15:49:19 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	"linux-rdma\@vger.kernel.org" <linux-rdma@...r.kernel.org>,
	"netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
	Liran Liss <liranl@...lanox.co.il>,
	Tziporet Koren <tziporet@...lanox.co.il>
Subject: Re: [PATCH 01/25 v2] mlx4_core: identify function as pf or vf


 > > I'm a bit confused by these flags.  As far as I can tell, the SRIOV flag will be set if and > only if MASTER is set too... so in other words we might as well just have the MASTER and > > SLAVE flags and not have the SRIOV flag at all.

 > We could have a situation where we have multiple physical functions, without SRIOV.
 > In this case one of the functions would be MASTER, but not SRIOV

Where in the code could that happen?  The only place I see the SRIOV or
MASTER flag get set is a line like:

	dev->flags |= MLX4_FLAG_SRIOV | MLX4_FLAG_MASTER;

so they are never used separately.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html