netdev - Re: [PATCH] starfire: Clean up properly if firmware loading fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4B5E5A5F.90608@moffatt.org.nz>
Date:	Tue, 26 Jan 2010 15:58:39 +1300
From:	Michael <michael@...fatt.org.nz>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org,
	bugzilla-daemon@...zilla.kernel.org,
	bugme-daemon@...zilla.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>, stable@...nel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] starfire: Clean up properly if firmware loading fails

Hi guys,

I think I'm the submitter that Ben is referring to.

So that could be the answer to the kernel BUG I have reported, but I 
don't think that it will answer why the interface doesn't come up... or 
does it?

Cheers,
Michael.

Ben Hutchings wrote:
> On Mon, 2010-01-25 at 18:15 -0800, Andrew Morton wrote:
>   
>> On Tue, 26 Jan 2010 02:02:12 +0000 Ben Hutchings <bhutchings@...arflare.com> wrote:
>>
>>     
>>> netdev_open() will return without cleaning up net device or hardware
>>> state if firmware loading fails.  This results in a BUG() on a second
>>> attempt to bring the interface up, reported in
>>> <http://bugzilla.kernel.org/show_bug.cgi?id=15117>, and probably has
>>> even worse effects if the driver is removed afterwards.
>>>       
>> (That's the wrong bugzilla URL)
>>     
>
> Hah, well spotted.  Must have copied from the wrong tab.
>
>   
>>> Call netdev_close() to clean up on failure.
>>>       
>> OK, thanks.
>>
>>     
>>> ---
>>> On Mon, 2010-01-25 at 17:08 -0800, Andrew Morton wrote: 
>>>       
>>>> (switched to email.  Please respond via emailed reply-to-all, not via the
>>>> bugzilla web interface).
>>>>
>>>> On Wed, 20 Jan 2010 04:29:20 GMT
>>>> bugzilla-daemon@...zilla.kernel.org wrote:
>>>>
>>>>         
>>>>> http://bugzilla.kernel.org/show_bug.cgi?id=15091
>>>>>
>>>>>            Summary: starfire causes kernel BUG when interface goes up
>>>>>           
>>> [...] 
>>>       
>>>>> I formerly used 2.6.20 and 2.6.24 with a couple of starfire 4 port ethernet
>>>>> cards. On 2.6.32 the interfaces don't start on boot and when I issue "ifconfig
>>>>> ethX up" (where X is a starfire port).
>>>>>           
>>> [...] 
>>>       
>>>> Starfire is triggering the BUG_ON(!test_bit(NAPI_STATE_SCHED,
>>>> &n->state)); in napi_enable().
>>>>
>>>> This is a regression somewhere between 2.6.24 and 2.6.32(!).
>>>>         
>>> This driver now attempts to load firmware when an interface is brought
>>> up, *after* calling napi_enable().  If that fails, it will return
>>> without calling napi_disable().  On the second attempt to bring the
>>> interface it calls napi_enable() a second time and triggers this
>>> assertion.
>>>
>>> As a workaround, try installing the necessary firmware. :-)
>>>
>>>       
>> Missing signed-off-by.  I added it, OK?  Also added a Cc:stable.
>>     
> [...]
>
> Well I was going to wait and see what the submitter says first, but I'm
> happy for you to add that in your patch set if it's a positive result.
>
> Ben.
>
>   

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html