netdev - Re: [PATCH] net/irda: sh_sir: Add SuperH IrDA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <ur5pan0pc.wl%morimoto.kuninori@renesas.com>
Date:	Thu, 28 Jan 2010 16:33:03 +0900
From:	Kuninori Morimoto <morimoto.kuninori@...esas.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org, Samuel Ortiz <samuel@...tiz.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net/irda: sh_sir: Add SuperH IrDA driver


Dear Stephen

Thank you for checking my code.

> > +struct sh_sir_self {
> > +	void __iomem		*membase;
> > +	unsigned int		 irq;
> > +	struct clk		*clk;
> > +
> > +	struct net_device	*ndev;
> > +
> > +	struct net_device_stats	stats;
> 
> The network device has stats in netdev->stats now
> so devices don't have to keep their own data structure.

Ohh. Thank you I understand.
I will fix it in v2

> Does the device support Fast IR mode?

Sorry. this chip is not advanced one.
it is SIR only

Best regards
--
Kuninori Morimoto
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html