netdev - Re: [PATCH] be2net: Bug fix to support newer generation of BE ASIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1264718429.373.520.camel@localhost>
Date:	Thu, 28 Jan 2010 22:40:29 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Ajit Khaparde <ajitk@...verengines.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, stable@...nel.org,
	stable-review@...nel.org
Subject: Re: [PATCH] be2net: Bug fix to support newer generation of BE ASIC

On Thu, 2010-01-28 at 13:26 +0530, Ajit Khaparde wrote:
> Bug fix in be2net for newer generation of BladeEngine ASIC.
[...]
> @@ -2162,6 +2168,7 @@ static int be_stats_init(struct be_adapter *adapter)
>  	cmd->va = pci_alloc_consistent(adapter->pdev, cmd->size, &cmd->dma);
>  	if (cmd->va == NULL)
>  		return -1;
> +	memset(cmd->va, cmd->size, 0);
>  	return 0;
>  }
>  
[...]

I don't think this does what you think it does.

Also, you should either send this patch to stable@...nel.org, or NAK the
addition of PCI ids for BladeEngine 3 in 2.6.32.7.

Ben.

-- 
Ben Hutchings
You can't have everything.  Where would you put it?

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)