netdev - Re: [PATCH] xfrm: avoid spinlock in get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100129151149.GD20701@kvack.org>
Date:	Fri, 29 Jan 2010 10:11:49 -0500
From:	Benjamin LaHaise <bcrl@...et.ca>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] xfrm: avoid spinlock in get_acqseq()

Hi Eric,

On Fri, Jan 29, 2010 at 03:05:52PM +0100, Eric Dumazet wrote:
> Use atomic_inc_return() in get_acqseq() to avoid taking a spinlock
> +	static atomic_t acqseq;

I think that needs to be:
	static atomic_t acqseq = ATOMIC_INIT(0);

Cheers,

	-ben
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html