lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4B6482AE.4060402@grandegger.com> Date: Sat, 30 Jan 2010 20:04:14 +0100 From: Wolfgang Grandegger <wg@...ndegger.com> To: "Pavel B. Cheblakov" <P.B.Cheblakov@....nsk.su> CC: Socketcan-core@...ts.berlios.de, netdev@...r.kernel.org Subject: Re: [PATCH net-next-2.6] can: add support for CAN interface cards based on the PLX90xx PCI bridge Wolfgang Grandegger wrote: > Hi Pavel, > > Pavel B. Cheblakov wrote: >> From: Pavel Cheblakov <P.B.Cheblakov@....nsk.su> >> >> This driver is for CAN interface cards based on the PLX90xx PCI bridge. >> Driver supports now: >> - Adlink PCI-7841/cPCI-7841 card (http://www.adlinktech.com/) >> - Adlink PCI-7841/cPCI-7841 SE card >> - Marathon CAN-bus-PCI card (http://www.marathon.ru/) >> - TEWS TECHNOLOGIES TPMC810 card (http://www.tews.com/) >> >> Signed-off-by: Pavel Cheblakov <P.B.Cheblakov@....nsk.su> > > We already discussed this patch on the Socketcan mailing list and it's > OK from my point of view. Please fix the minor issues reported by Daniel > Baluta. To v2 of the patch you can then add directly my > "Acked-by: Wolfgang Grandegger <wg@...ndegger.com>" I just realized one more issue. The driver creates section mismatches. Please use "static DEFINE_PCI_DEVICE_TABLE(plx_pci_tbl)" as, for example, the ems_pci driver does. Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists