netdev - Re: [PATCH net-next-2.6] net: use helpers to access mc list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 02 Feb 2010 09:03:02 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net: use helpers to access mc list

From: Jiri Pirko <jpirko@...hat.com>
Date: Tue, 2 Feb 2010 17:31:08 +0100

> Tue, Feb 02, 2010 at 05:06:01PM CET, davem@...emloft.net wrote:
>>From: Jiri Pirko <jpirko@...hat.com>
>>Date: Tue, 2 Feb 2010 17:03:48 +0100
>>
>>> You mean "struct dev_mc_list"? But that would solve nothing. If I would still
>>> use current structure in drivers, then still the migration to struct_hw_addr
>>> would be all-at-once for all drivers :( This patch was exacly made to avoid
>>> this.
>>
>>I think changing the iterator type will have to be done
>>wholesale in one changeset, there is no reasonable way
>>to avoid it.
> 
> So what you are proposing is to change drivers' code to use macro to iterate
> through lists as step n1 and then change the iterator type as step n2 right?
> 
> If we would use my patch, we would have this done in single step. But I understand
> that a kind of ugliness patch introduces is simply not acceptable not even for a
> short time period, right?

Right.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html