netdev - Re: [PATCH 2/2] virtio_net: Defer skb allocation in receive path Date: Wed, 13 Jan 2010 12:53:38 -0800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100202.155916.136472373.davem@davemloft.net>
Date:	Tue, 02 Feb 2010 15:59:16 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	rusty@...tcorp.com.au
Cc:	netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
	mashirle@...ibm.com, mst@...hat.com
Subject: Re: [PATCH 2/2] virtio_net: Defer skb allocation in receive path
 Date: Wed, 13 Jan 2010 12:53:38 -0800

From: Rusty Russell <rusty@...tcorp.com.au>
Date: Fri, 29 Jan 2010 23:50:04 +1030

> From: Shirley Ma <mashirle@...ibm.com>
> 
> virtio_net receives packets from its pre-allocated vring buffers, then it 
> delivers these packets to upper layer protocols as skb buffs. So it's not
> necessary to pre-allocate skb for each mergable buffer, then frees extra 
> skbs when buffers are merged into a large packet. This patch has deferred 
> skb allocation in receiving packets for both big packets and mergeable buffers
> to reduce skb pre-allocations and skb frees. It frees unused buffers by calling 
> detach_unused_buf in vring, so recv skb queue is not needed.
> 
> Signed-off-by: Shirley Ma <xma@...ibm.com>
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html