netdev - Re: [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter programming support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100204.091854.24215476.davem@davemloft.net>
Date:	Thu, 04 Feb 2010 09:18:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter
 programming support

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 03 Feb 2010 23:48:13 -0800

> +#define ETHTOOL_RXNTUPLE_ACTION_DROP -1
> +	struct list_head list;
> +};

You can't do this.

You put the list_head here in the kernel header, which BTW can
be used by userspace too, and then you elide it in the
ethtool utility copy of the header.

Use an encapsulator if you must inside of the kernel, but keep the
userspace visible data structure clean of RCU and list_head
kernel datastructures.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html