netdev - Re: [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter programming support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B6B4B87.6020500@garzik.org>
Date:	Thu, 04 Feb 2010 17:34:47 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
CC:	David Miller <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>
Subject: Re: [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter
 programming support

On 02/04/2010 04:26 PM, Waskiewicz Jr, Peter P wrote:
> On Thu, 4 Feb 2010, David Miller wrote:
>
>> From: Jeff Kirsher<jeffrey.t.kirsher@...el.com>
>> Date: Wed, 03 Feb 2010 23:48:13 -0800
>>
>>> +#define ETHTOOL_RXNTUPLE_ACTION_DROP -1
>>> +	struct list_head list;
>>> +};
>>
>> You can't do this.
>>
>> You put the list_head here in the kernel header, which BTW can
>> be used by userspace too, and then you elide it in the
>> ethtool utility copy of the header.
>>
>> Use an encapsulator if you must inside of the kernel, but keep the
>> userspace visible data structure clean of RCU and list_head
>> kernel datastructures.
>
> Ok.  I'll respin this asap.  Thanks for the quick review Dave.

Great.  I'll look for the updated userspace patch, too, and put it into 
the ethtool-2.6.34 pile (ie. ethtool-net-next).

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html