netdev - Re: [PATCH 2.6.33 4/4] net: Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100204.154031.124668996.davem@davemloft.net>
Date:	Thu, 04 Feb 2010 15:40:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Tristram.Ha@...rel.Com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.33 4/4] net: Add PCI vendor and device ids for
 Micrel KSZ8841/2 PCI devices

From: "Ha, Tristram" <Tristram.Ha@...rel.Com>
Date: Thu, 4 Feb 2010 15:28:29 -0800

> From: Tristram Ha <Tristram.Ha@...rel.com>
> 
> Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices.
> 
> Signed-off-by: Tristram Ha <Tristram.Ha@...rel.com>

We no longer add device ID defines to the linux/pci_ids.h
file, in fact it's been this way for several years.

Just use constants or local devices in your driver.

Furthermore, because you made this the last patch, the
tree would fail to build at the point where the first
three of your patches are applied.

This breaks GIT bisection, and is severely frowned upon.  The tree
must build with all available kernel config options enabled at every
step of applying your set of patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html