[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100203.190154.46617335.davem@davemloft.net>
Date: Wed, 03 Feb 2010 19:01:54 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: nhorman@...driver.com
Cc: gerrit@....abdn.ac.uk, dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 01/86] dccp: fix bug in cache allocation
From: Neil Horman <nhorman@...driver.com>
Date: Mon, 1 Feb 2010 06:56:38 -0500
> On Mon, Feb 01, 2010 at 07:18:06AM +0100, Gerrit Renker wrote:
>> This fixes a bug introduced in commit de4ef86cfce60d2250111f34f8a084e769f23b16
>> ("dccp: fix dccp rmmod when kernel configured to use slub", 17 Jan): the
>> vsnprintf used sizeof(slab_name_fmt), which became truncated to 4 bytes, since
>> slab_name_fmt is now a 4-byte pointer and no longer a 32-character array.
>>
>> This lead to error messages such as
>> FATAL: Error inserting dccp: No buffer space available
>>
>> >> kernel: [ 1456.341501] kmem_cache_create: duplicate cache cci
>> generated due to the truncation after the 3rrdc character.
>>
>> Fixed for the moment by introducing a symbolic constant. Tested to fix the bug.
>>
>> Signed-off-by: Gerrit Renker <gerrit@....abdn.ac.uk>
>
> These changes make sense, sorry for not seeing that earlier. Thanks!
>
> Acked-by: Neil Horman <nhorman@...driver.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists