netdev - Re: [net-next-2.6 PATCH v2] ixgbe: only process one ixgbe_watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100203.194707.57344587.davem@davemloft.net>
Date:	Wed, 03 Feb 2010 19:47:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	john.r.fastabend@...el.com
Subject: Re: [net-next-2.6 PATCH v2] ixgbe: only process one
 ixgbe_watchdog_task at a time.

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 03 Feb 2010 16:23:32 -0800

> From: John Fastabend <john.r.fastabend@...el.com>
> 
> Processing multiple ixgbe_watchdog_task calls may cause
> the link_up variable and IXGBE_FLAG_NEED_LINK_UPDATE flag
> to be set incorrectly.  In the worse case this is causing
> the netif_carrier_off to be called inappropriately which
> results in an interface that can't be brought up.
> 
> Although schedule_work() will only schedule the task if
> it is not already on the work queue the WORK_STRUCT_PENDING
> bits are cleared just before calling the work function.
> This allows WORK_STRUCT_PENDING to be cleared, the work
> function to start and meanwhile schedule another task.
> 
> This patch adds a mutex to the watchdog task. This bug is
> actualized by changing DCB settings or doing extended
> cable pull or reset tests.
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html