netdev - Re: [PATCH 11/13] net: irda: use seq_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B6C051F.3080702@gmail.com>
Date:	Fri, 05 Feb 2010 13:46:39 +0200
From:	Paulius Zaleckas <paulius.zaleckas@...il.com>
To:	Li Zefan <lizf@...fujitsu.com>
CC:	David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 11/13] net: irda: use seq_list_foo() helpers

On 02/05/2010 03:47 AM, Li Zefan wrote:
[...]
>   /* Return entry after v, and increment pos */
> @@ -1148,14 +1137,7 @@ static void *irlan_seq_next(struct seq_file *seq, void *v, loff_t *pos)
>   {
>   	struct list_head *nxt;

you should remove nxt declaration.

> -	++*pos;
> -	if (v == SEQ_START_TOKEN)
> -		nxt = irlans.next;
> -	else
> -		nxt = ((struct irlan_cb *)v)->dev_list.next;
> -
> -	return (nxt ==&irlans) ? NULL
> -		: list_entry(nxt, struct irlan_cb, dev_list);
> +	return seq_list_next(v,&irlans, pos);
>   }
[...]
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html