netdev - Re: [PATCH] obsolete config in kernel source (HSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100205151402.GB7299@faui49.informatik.uni-erlangen.de>
Date:	Fri, 5 Feb 2010 16:14:02 +0100
From:	Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>
To:	Paulius Zaleckas <paulius.zaleckas@...il.com>
Cc:	Jan Dumon <j.dumon@...ion.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] obsolete config in kernel source (HSO_AUTOPM)

On Fri, Feb 05, 2010 at 04:38:48PM +0200, Paulius Zaleckas wrote:
> On 02/05/2010 03:39 PM, Christoph Egger wrote:
> >Hi all!
> >
> >	As part of the VAMOS[0] research project at the University of
> >Erlangen we're checking referential integrity between kernel KConfig
> >options and in-code Conditional blocks.
> >
> >	This is just a one-liner commented out unconditionally (due to
> >the config not existing) and being like this for virtually ever so I'm
> >suggesting to remove it from the kernel tree.
> >
> >	Please keep me informed of this patch getting confirmed /
> >merged so we can keep track of it.
> >
> >diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
> >index 6895f15..be0cc99 100644
> >--- a/drivers/net/usb/hso.c
> >+++ b/drivers/net/usb/hso.c
> >@@ -1155,9 +1155,6 @@ static void _hso_serial_set_termios(struct tty_struct *tty,
> >  static void hso_resubmit_rx_bulk_urb(struct hso_serial *serial, struct urb *urb)
> >  {
> >  	int result;
> >-#ifdef CONFIG_HSO_AUTOPM
> >-	usb_mark_last_busy(urb->dev);
> >-#endif
> 
> Acctually this is bug. usb_mark_last_busy() should be called here.
> Can you resend this patch by just removing #ifdef and #endif and
> leaving usb_mark_last_busy()?

OK here comes the updated patch

-----
>From f9797bb502566cd9e4db8b1bb7bb213f7f1d64ed Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>
Date: Fri, 5 Feb 2010 16:10:29 +0100
Subject: [PATCH] Remove unreferenced HSO_AUTOPM

CONFIG_HSO_AUTOPM is not set by KConfig / set in the Kernel source,
makefiles and won't be ever set this way. However the unreachable code
is actually needed as reported by Paulius Zaleckas so just removing
the checks.

Signed-off-by: Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>
---
 drivers/net/usb/hso.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 6895f15..de466ee 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1155,9 +1155,7 @@ static void _hso_serial_set_termios(struct tty_struct *tty,
 static void hso_resubmit_rx_bulk_urb(struct hso_serial *serial, struct urb *urb)
 {
 	int result;
-#ifdef CONFIG_HSO_AUTOPM
 	usb_mark_last_busy(urb->dev);
-#endif
 	/* We are done with this URB, resubmit it. Prep the USB to wait for
 	 * another frame */
 	usb_fill_bulk_urb(urb, serial->parent->usb,
-- 
1.6.3.3


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html