netdev - Re: MAX_SKB_FRAGS and GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100208222135.GA14188@gondor.apana.org.au>
Date:	Tue, 9 Feb 2010 09:21:35 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Cc:	Anton Blanchard <anton@...ba.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Duyck, Alexander H" <alexander.h.duyck@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"divy@...lsio.com" <divy@...lsio.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: MAX_SKB_FRAGS and GRO

On Mon, Feb 08, 2010 at 09:41:58AM -0800, Brandeburg, Jesse wrote:
>  
> > In fact I think the ixgbe code may be broken as it is since it's
> > not marking RSC packets in any way to prevent them from being
> > forwarded through another interface.
> 
> Herbert, what are we missing? Is there some interface for us to do what 
> you describe?  do we need to set DODGY?

The problem is that AFAIK RSC does not impose enough restrictions
on what is merged.  This means that information is lost during the
merge process.  IOW if the merged packet is forwarded we cannot
regenerate the original fragments exactly.

Therefore whenever bridging/routing is used on that interface RSC
must be turned off.

The easiest way to do this is to do what LRO does, which is to
set gso_type to zero and gso_size non-zero.  Of course you'll
also need to use the LRO toggle to control whether RSC is enabled
or not.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html