netdev - RE: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a99fdf2-8fd0-4fd0-9cbb-fe6c87d5f50e@SG2EHSMHS015.ehs.local>
Date:	Tue, 9 Feb 2010 08:57:10 -0700
From:	John Linn <John.Linn@...inx.com>
To:	"Grant Likely" <grant.likely@...retlab.ca>
CC:	<netdev@...r.kernel.org>, <linuxppc-dev@...abs.org>,
	<jgarzik@...ox.com>, <jwboyer@...ux.vnet.ibm.com>,
	<john.williams@...alogix.com>,
	"Sadanand Mutyala" <sadanan@...inx.com>
Subject: RE: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support

> -----Original Message-----
> From: glikely@...retlab.ca [mailto:glikely@...retlab.ca] On Behalf Of Grant Likely
> Sent: Tuesday, February 09, 2010 8:45 AM
> To: John Linn
> Cc: netdev@...r.kernel.org; linuxppc-dev@...abs.org; jgarzik@...ox.com; jwboyer@...ux.vnet.ibm.com;
> john.williams@...alogix.com; Sadanand Mutyala
> Subject: Re: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support
> 
> On Mon, Feb 8, 2010 at 7:09 AM, John Linn <John.Linn@...inx.com> wrote:
> >> -----Original Message-----
> >> From: John Linn [mailto:john.linn@...inx.com]
> >> Sent: Friday, February 05, 2010 3:41 PM
> >> To: netdev@...r.kernel.org; linuxppc-dev@...abs.org;
> > jgarzik@...ox.com; grant.likely@...retlab.ca;
> >> jwboyer@...ux.vnet.ibm.com
> >> Cc: john.williams@...alogix.com; John Linn; Sadanand Mutyala
> >> Subject: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support
> >>
> >> These changes add MDIO and phy lib support to the driver as the
> >> IP core now supports the MDIO bus.
> >>
> >> The MDIO bus and phy are added as a child to the emaclite in the
> > device
> >> tree as illustrated below.
> >>
> >> mdio {
> >>       #address-cells = <1>;
> >>       #size-cells = <0>;
> >>       compatible = "xlnx,emaclite-mdio";
> >>       phy0: phy@7 {
> >>               reg = <7>;
> >>       } ;
> >> }
> 
> You misunderstood me about the compatible property.  You don't need a
> compatible prop in the mdio node because it is *alwasy* a child of the
> emaclite node, and the emaclite driver knows to go looking for it (ie.
> it is a part of the device).

OK, now I see, sorry for my denseness there.

> 
> What I want to see is a compatible value in the phy@7 node for the
> make & model of the phy.

Makes more sense.

> 
> Otherwise, looks good to me.  Fix the mutex timeout problem and then
> you can add my acked-by line to the patch.

Will spin V3 patch with fixes and add your ack, appreciate the help and your patience.

- John

> 
> Cheers,
> g.


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html