netdev - Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Feb 2010 08:30:24 +1000
From:	John Williams <john.williams@...alogix.com>
To:	John Linn <john.linn@...inx.com>
Cc:	netdev@...r.kernel.org, linuxppc-dev@...abs.org, jgarzik@...ox.com,
	grant.likely@...retlab.ca, jwboyer@...ux.vnet.ibm.com,
	Sadanand Mutyala <Sadanand.Mutyala@...inx.com>
Subject: Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

Hi John,

Sorry If I'm painting bike-sheds here, just one tiny tweak might be in
order to standardise your mutex_unlock exit path:

> +static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg)
> +{
> +       struct net_local *lp = bus->priv;
> +       u32 ctrl_reg;
> +       u32 rc;
> +
> +       mutex_lock(&lp->mdio_mutex);
> +
> +       if (xemaclite_mdio_wait(lp)) {
> +               mutex_unlock(&lp->mdio_mutex);
> +               return -ETIMEDOUT;
> +       }

[snip]


> +       if (xemaclite_mdio_wait(lp)) {
> +               mutex_unlock(&lp->mdio_mutex);
> +               return -ETIMEDOUT;
> +       }

[snip]


> +       dev_dbg(&lp->ndev->dev,
> +               "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n",
> +               phy_id, reg, rc);
> +
> +       return rc;

Can this be better expressed like this:

my_func() {
  mutex_lock()
..

  if(some error) {
    rc=-ETIMEDOUT;
    goto out_unlock;
  }
  ...

  /* success path */
  rc=0;
..
out_unlock:
  mutex_unlock()
  return rc;
}


Is this style still favoured in driver exit paths?

Thanks,

John
-- 
John Williams, PhD, B.Eng, B.IT
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com  p: +61-7-30090663  f: +61-7-30090663
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html