netdev - Re: bnx2 limits user-specified advertised speeds to one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1265839887.8125.39.camel@nseg_linux_HP1.broadcom.com>
Date:	Wed, 10 Feb 2010 14:11:27 -0800
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Vlad Yasevich" <vladislav.yasevich@...com>
cc:	netdev <netdev@...r.kernel.org>
Subject: Re: bnx2 limits user-specified advertised speeds to one


On Wed, 2010-02-10 at 13:05 -0800, Vlad Yasevich wrote:
> Hi
> 
> A customer has noted that when attempting to change the advertised speeds
> setting on card using a bnx2 driver, the driver advertises either all available
> speeds or just one.  In other words, if a user attempts to set multiple
> advertised speeds,  the settings will not be honored.
> 
> Looking at the code in bnx2_set_settings, the checks for 10baseT and 100baseT
> make an assumption that the user provided only 1 speed setting.
> 
> e1000 and e1000e work correctly when the user specifies multiple advertised
> speeds.
> 
> Before attempting to fix this, I wanted to ask if there was a reason for the
> current functionality.
> 

Probably code to handle limitations in older versions of the ethtool
program.  There is no reason for it to be like this anymore.  I'll fix
this in my next patch set.  Thanks for reporting this.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html