netdev - Re: [PATCH 2/5] sky2: Allocate initial skbs in sky2_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100210080452.75ee8ab2@nehalam>
Date:	Wed, 10 Feb 2010 08:04:52 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Mike McCormack <mikem@...g3k.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/5] sky2: Allocate initial skbs in sky2_alloc_buffers

On Wed, 10 Feb 2010 23:12:01 +0900
Mike McCormack <mikem@...g3k.org> wrote:

> +		re->skb = sky2_rx_alloc(sky2);
> +		if (!re->skb)
> +			goto nomem;
> +
> +		if (sky2_rx_map_skb(hw->pdev, re, sky2->rx_data_size)) {
> +			dev_kfree_skb(re->skb);
> +			re->skb = NULL;
> +			goto nomem;
> +		}
> +	}
> +	return 0;
> +nomem:
> +	return -ENOMEM;

I like this and will put it all together with my patch set
But will get rid of silly things goto a return statement.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html