netdev - Re: [PATCH 5/5] sky2: Avoid down and up during sky2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100210093408.38a7f817@nehalam>
Date:	Wed, 10 Feb 2010 09:34:08 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Mike McCormack <mikem@...g3k.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/5] sky2: Avoid down and up during sky2_reset

On Wed, 10 Feb 2010 23:12:25 +0900
Mike McCormack <mikem@...g3k.org> wrote:

> +	if (!interrupts_disabled) {
> +		/* Disable port IRQ */
> +		u32 imask = sky2_read32(hw, B0_IMSK);
> +		imask &= ~portirq_msk[port];
> +		sky2_write32(hw, B0_IMSK, imask);
> +		sky2_read32(hw, B0_IMSK);
>  

I don't like conditional context like this. It makes code
hard to debug, etc. Could you change sky2_down to do the irq
cleanup before calling hw_down?

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html