netdev - Re: ixgbe RSS not working as expected with 8021q and bridging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100212190340.GB20231@esk.cs.usu.edu>
Date:	Fri, 12 Feb 2010 12:03:40 -0700
From:	Eldon Koyle <esk-netdev@....cs.usu.edu>
To:	netdev@...r.kernel.org
Cc:	eric.dumazet@...il.com
Subject: Re: ixgbe RSS not working as expected with 8021q and bridging

On  Feb 10 13:50-0700, Eldon Koyle wrote:
<snip>
> I am now trying 2.6.32.7 with the in-tree ixgbe driver.  I am still
> seeing some unusual behavior when bridging VLAN interfaces.  It looks
> like there is an off-by-one error in the mapping from rx queue to tx
> queue (ie. packets are sent on <rx queue number>-1 instead of using the
> same rx and tx queue number).
> 
> Any idea what might cause this?

Looking at the code, we are having difficulty finding the problem.  I
think we did find an accounting error in the vlan code, though.

In net/8021q/vlan_dev.c:

static netdev_tx_t vlan_dev_hard_start_xmit(struct sk_buff *skb,
                                            struct net_device *dev)
{
        int i = skb_get_queue_mapping(skb);
        struct netdev_queue *txq = netdev_get_tx_queue(dev, i);      
...
        if (likely(ret == NET_XMIT_SUCCESS)) {
                txq->tx_packets++;
                txq->tx_bytes += len;
        } else
                txq->tx_dropped++;
...
}

skb_get_queue_mapping returns skb->queue_mapping, which is rx_queue + 1
or 0 for unset.

Does dev->_tx[0] have some special meaning, or is this wrong?

-- 
Eldon Koyle
-- 
I have a theory that it's impossible to prove anything, but I can't prove it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html