netdev - Re: [RFC PATCH net-next 0/7] Add netdev_printk and netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100212.123129.163263355.davem@davemloft.net>
Date:	Fri, 12 Feb 2010 12:31:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com
Subject: Re: [RFC PATCH net-next 0/7] Add netdev_printk and netif_printk
 macros

From: Joe Perches <joe@...ches.com>
Date: Tue,  9 Feb 2010 13:49:46 -0800

> Some logging messages duplicate the driver name with the device name like:
> 
> ATL1E 0000:03:00.0: ATL1E: eth0 NIC Link is Up<100 Mbps Full Duplex>
>  
> Some drivers/net/... have created netif_ macros like:
> 
> drivers/net/sis190.c:#define net_drv(p, arg...)		if (netif_msg_drv(p)) \
> drivers/net/sis190.c-					printk(arg)
> drivers/net/sis190.c:#define net_probe(p, arg...)	if (netif_msg_probe(p)) \
> drivers/net/sis190.c-					printk(arg)
> drivers/net/sis190.c:#define net_link(p, arg...)	if (netif_msg_link(p)) \
> drivers/net/sis190.c-					printk(arg)
> drivers/net/sis190.c:#define net_intr(p, arg...)	if (netif_msg_intr(p)) \
> drivers/net/sis190.c-					printk(arg)
> drivers/net/sis190.c:#define net_tx_err(p, arg...)	if (netif_msg_tx_err(p)) \
> drivers/net/sis190.c-					printk(arg)
> 
> This RFC patch creates a set of these macros to standardize
> the coding and logging style of struct net_device and netif_msg macros
> 
> I think they're useful, might be mindless churn to others.
> 
> The atl1e change reduces log duplicate names.
> 
> The qlge change is an example of what be mindless churn for standardization
> sake, the r8169, jme, and skge are more reasonable.
> 
> Comments?

I really like these changes, feel free to make a pass of niu.[ch] making it
use these things :-)

All applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html