netdev - Re: bug and question in tcp stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100212.153907.71316958.davem@davemloft.net>
Date:	Fri, 12 Feb 2010 15:39:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	caoco2002@...oo.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: bug and question in tcp stack

From: Joe Cao <caoco2002@...oo.com>
Date: Fri, 12 Feb 2010 15:22:16 -0800 (PST)

> if (tcp_retransmit_skb(sk, tcp_write_queue_head(sk)) > 0) {
> 
> checks the return value as a positive number, which will never be true.

It can, recheck the code paths.

The upcall to send an SKB out through the packet schedular and onwards
to the actual device can return congestion notification values, which
are positive.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html