netdev - includes build break - was Re: [net-next-2.6 PATCH v5 0/3] Introduce n-tuple ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B77E4EC.30407@hartkopp.net>
Date:	Sun, 14 Feb 2010 12:56:28 +0100
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	David Miller <davem@...emloft.net>, peter.p.waskiewicz.jr@...el.com
CC:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com
Subject: includes build break - was Re: [net-next-2.6 PATCH v5 0/3] Introduce
 n-tuple ethtool support

David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Wed, 10 Feb 2010 18:07:18 -0800
> 
>> One more round of fixes, based on feedback from Patrick McHardy
>>
>> 1) Change the list count to an unsigned value
>> 2) Fix a memory leak
>> 3) Removed an unnecessary list traversal in the ethtool core
>> 4) Moved all list destruction to a helper function, allowing the driver
>> to control when it clears the list (aside from when free_netdev() kills
>> the cached list).
> 
> All applied, thanks.
> 

Hi Peter,

compiling the latest net-next-2.6 i got this problem:
 
  CHECK   include/linux (358 files)
/home/hartko/net-next-2.6/usr/include/linux/ethtool.h:17: included file 'linux/rculist.h' is not exported

Which has been introduced by

http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=15682bc488d4af8c9bb998844a94281025e0a333

("ethtool: Introduce n-tuple filter programming support")

The patch below fixes the issue.

Signed-off-by: Oliver Hartkopp <oliver@...tkopp.net>

---

diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index a3cac53..83a9a53 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -14,7 +14,9 @@
 #define _LINUX_ETHTOOL_H
 
 #include <linux/types.h>
+#ifdef __KERNEL__
 #include <linux/rculist.h>
+#endif
 
 /* This should work for both 32 and 64 bit userland. */
 struct ethtool_cmd {
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html