netdev - Re: [PATCH] atm : fix /sys/devices/virtual/atm/X/carrier(ATM_PHY_SIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201002142134.o1ELYehH019725@thirdoffive.cmf.nrl.navy.mil>
Date:	Sun, 14 Feb 2010 16:34:40 -0500
From:	"Chas Williams (CONTRACTOR)" <chas@....nrl.navy.mil>
To:	Philippe De Muyter <phdm@...qel.be>
cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] atm : fix /sys/devices/virtual/atm/X/carrier(ATM_PHY_SIG_UNKNOWN)

In message <20100214175136.GA15891@...lo.macqel>,Philippe De Muyter writes:
>OK for me.  I would agree with
>
>	carrier = 0 when signal == ATM_PHY_SIG_UNKNOWN,
>
>but currently we have
>
>	carrier = 1 when signal == ATM_PHY_SIG_UNKNOWN

not quite what i said (or perhaps i didnt clearly convey my intent).
ATM_PHY_SIG_UNKNOWN is set during the driver create/initialize.
unfortunately, some drivers never bothers to set signal so it winds up
always being unknown.  however, for those drivers, we cant assume the
carrier is 0, or nothing will happen if someone is watching for the
carrier to be 1.

so, all drivers, if they arent going to support setting signal should
just assign it to 1.  i would sort of prefer that ATM_PHY_SIG_UNKNOWN
simply didnt exist.  as i said before there is carrier or there is
not.  if the driver doesnt support checking/knowing the carrier status
it should simply say 'yes i have carrier'.

i will see if i cant workup a little patch for this today.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html