netdev - Re: [PATCH 1/2] macvtap: rework object lifetime rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9ae48b021002151548l79b8c5fdycc04a2f36fed1f09@mail.gmail.com>
Date:	Mon, 15 Feb 2010 15:48:40 -0800
From:	Ed Swierk <eswierk@...stanetworks.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Patrick McHardy <kaber@...sh.net>,
	Sridhar Samudrala <sri@...ibm.com>, qemu-devel@...gnu.org,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH 1/2] macvtap: rework object lifetime rules

On Sat, Feb 13, 2010 at 2:33 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The original macvtap code has a number of problems
> resulting from the use of RCU for protecting the
> access to struct macvtap_queue from open files.
>
> This includes
> - need for GFP_ATOMIC allocations for skbs
> - potential deadlocks when copy_*_user sleeps
> - inability to work with vhost-net
>
> Changing the lifetime of macvtap_queue to always
> depend on the open file solves all these. The
> RCU reference simply moves one step down to
> the reference on the macvlan_dev, which we
> only need for nonblocking operations.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

This works for me.

Acked-by: Ed Swierk <eswierk@...stanetworks.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html