netdev - Re: [PATCH net-next] niu.c: Use pr_<level>, netdev_<level> and netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100214.224108.51485961.davem@davemloft.net>
Date:	Sun, 14 Feb 2010 22:41:08 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com
Subject: Re: [PATCH net-next] niu.c: Use pr_<level>, netdev_<level> and
 netif_<level> macros

From: Joe Perches <joe@...ches.com>
Date: Sun, 14 Feb 2010 16:47:09 -0800

> OK David, here you go.
> 
> I'm not sure of the conversions of:
> 	dev_<level>(np->device,...
> to
> 	netdev_<level>(np->dev,...
> 
> It compiles, but dunno if it's correct (no hw to test)
> 
> Remove #define PFX
> Add pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Convert printks to pr_<level>
> Convert printks without levels to pr_cont
> Convert pr_<level> with np->dev to netdev_<level>
> Convert dev_<level> to netdev_<level>
> Convert niudbg to netif_printk
> Convert niuinfo, niuwarn macros to netif_<level>(priv, type, dev...
> Coalesce long formats
> Convert embedded function names to "%s", __func__
> Always use "%s()..." when __func__ is printed
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Thanks Joe.

It looks good here and I'll give it a quick test before
doing a final push of this into net-next-2.6

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html