netdev - Re: [PATCH net-next] niu.c: Use pr_<level>, netdev_<level> and netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1266222199.16721.967.camel@Joe-Laptop.home>
Date:	Mon, 15 Feb 2010 00:23:19 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com
Subject: Re: [PATCH net-next] niu.c: Use pr_<level>, netdev_<level> and
 netif_<level> macros

On Mon, 2010-02-15 at 00:13 -0800, David Miller wrote:
> I just added the following refinements on top of your
> changes to net-next-2.6
[]
> drivers/net/niu.c |   26 +-------------------------
>  1 files changed, 1 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/net/niu.c b/drivers/net/niu.c
> index 347788f..5e604e3 100644
> --- a/drivers/net/niu.c
> +++ b/drivers/net/niu.c
[]
> @@ -4246,13 +4241,11 @@ static irqreturn_t niu_interrupt(int irq, void *dev_id)
>  	v2 = nr64(LDSV2(ldg));
>  
>  	if (netif_msg_intr(np))
> -		pr_cont(" v0[%llx] v1[%llx] v2[%llx]",
> +		pr_cont(" v0[%llx] v1[%llx] v2[%llx]\n",
>  		       (unsigned long long) v0,
>  		       (unsigned long long) v1,
>  		       (unsigned long long) v2);
>  
> -	pr_cont("\n");
> -
>  	if (unlikely(!v0 && !v1 && !v2)) {
>  		spin_unlock_irqrestore(&np->lock, flags);
>  		return IRQ_NONE;
 
This creates a logging message without trailing \n
if netif_msg_intr is false.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html