netdev - Re: [PATCH net-next] niu.c: Use pr_<level>, netdev_<level> and netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1266223253.16721.974.camel@Joe-Laptop.home>
Date:	Mon, 15 Feb 2010 00:40:53 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com
Subject: Re: [PATCH net-next] niu.c: Use pr_<level>, netdev_<level> and
 netif_<level> macros

On Mon, 2010-02-15 at 00:30 -0800, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Mon, 15 Feb 2010 00:23:19 -0800
> 
> > This creates a logging message without trailing \n
> > if netif_msg_intr is false.
> 
> How so?  The first message in this function is keyed
> off of 'intr' message debugging flag.

Quite right.  I misread it.

It might be better to move/merge the two parts of
the message.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html