lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Feb 2010 13:48:42 +0100 From: Andi Kleen <andi@...stfloor.org> To: William Allen Simpson <william.allen.simpson@...il.com> Cc: Linux Kernel Developers <linux-kernel@...r.kernel.org>, Linux Kernel Network Developers <netdev@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, David Miller <davem@...emloft.net>, Andi Kleen <andi@...stfloor.org> Subject: Re: [PATCH v5 3/7] tcp: harmonize tcp_vx_rcv header length assumptions On Mon, Feb 15, 2010 at 07:28:44AM -0500, William Allen Simpson wrote: > Harmonize tcp_v4_rcv() and tcp_v6_rcv() -- better document tcp doff > and header length assumptions, and carefully compare implementations. > > Reduces multiply/shifts, marginally improving speed. > > Removes redundant tcp header length checks before checksumming. > > Instead, assumes (and documents) that any backlog processing and > transform policies will carefully preserve the header, and will > ensure the socket buffer length remains >= the header size. I reviewed the patch and it looks ok to me. As far as I can see it's mostly manual CSE, no real behaviour change. Normally it's customary to separate formatting changes from real changes, but it was only in a few places and not too bad. I didn't fully understand that new comment: /* nf_reset(skb); in ip6_input.c ip6_input_finish() */ Overall you can add a Reviewed-by: Andi Kleen <andi@...stfloor.org> -Andi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists