netdev - Re: IPv6 20/62: reassembly: replace magic number with macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B7ABDF8.8010004@trash.net>
Date:	Tue, 16 Feb 2010 16:47:04 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Joe Perches <joe@...ches.com>
CC:	Shan Wei <shanwei@...fujitsu.com>, davem@...emloft.net,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: IPv6 20/62: reassembly: replace magic number with macro definitions

Joe Perches wrote:
>> @@ -246,6 +246,8 @@ extern int ipv6_opt_accepted(struct sock *sk, struct sk_buff *skb);
>>  int ip6_frag_nqueues(struct net *net);
>>  int ip6_frag_mem(struct net *net);
>>  
>> +#define IPV6_FRAG_HIGH_THRESH	262144		/* == 256*1024 */
>> +#define IPV6_FRAG_LOW_THRESH	196608		/* == 192*1024 */
>>  #define IPV6_FRAG_TIMEOUT	(60*HZ)		/* 60 seconds */
> 
> 196608 isn't a number I want to remember.
> Is this better as:
> 
> #define IPV6_FRAG_HIGH_THRESH	(256 * 1024)	/* 262144 */
> #define IPV6_FRAG_LOW_THRESH	(192 * 1024)	/* 196608 */

Please send a patch, I'll apply it once these patches are in Dave's
tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html