netdev - Re: [PATCH] SiS190/191 half-duplex initialization fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100216.144756.71882700.davem@davemloft.net>
Date:	Tue, 16 Feb 2010 14:47:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	birrachiara@....it
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org
Subject: Re: [PATCH] SiS190/191 half-duplex initialization fix

From: Riccardo Ghetta <birrachiara@....it>
Date: Mon, 15 Feb 2010 21:19:00 +0100

> +        u32 negotiated_lpa;

Uses spaces instead of tabs.

> + 		tp->negotiated_lpa = p->val;

Has a space then tabs, should be all tab characters.

> +	if (tp->negotiated_lpa & (LPA_1000HALF | LPA_100HALF | LPA_10HALF))
> +	{

Should be:

	if (condition) {

ie. the openning brace need to be on the same line as the if
statement.

Please fix these issues up and resubmit your patch, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html