netdev - Re: [PATCH] ipcomp: double free at ipcomp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100216.151446.66294061.davem@davemloft.net>
Date:	Tue, 16 Feb 2010 15:14:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	adobriyan@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] ipcomp: double free at ipcomp_destroy()

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 16 Feb 2010 14:00:51 +0800

> On Mon, Feb 15, 2010 at 04:08:46PM +0800, Herbert Xu wrote:
>>
>> Doh, I was looking at the buggy xfrm_state_clone path (which
>> incidently needs to be fixed to use xfrm_state_put).
> 
> Here's a fix for that problem.
> 
> xfrm: Fix xfrm_state_clone leak
> 
> xfrm_state_clone calls kfree instead of xfrm_state_put to free
> a failed state.  Depending on the state of the failed state, it
> can cause leaks to things like module references.
> 
> All states should be freed by xfrm_state_put past the point of
> xfrm_init_state.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied to net-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html