netdev - Re: [PATCH v5 3/7] tcp: harmonize tcp_vx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100217.154734.177239957.davem@davemloft.net>
Date:	Wed, 17 Feb 2010 15:47:34 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	william.allen.simpson@...il.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	akpm@...ux-foundation.org, andi@...stfloor.org
Subject: Re: [PATCH v5 3/7] tcp: harmonize tcp_vx_rcv header length
 assumptions

From: William Allen Simpson <william.allen.simpson@...il.com>
Date: Sun, 14 Feb 2010 01:16:28 -0500

> @@ -1559,7 +1559,8 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
>  		return 0;
>  	}
>  
> -	if (skb->len < tcp_hdrlen(skb) || tcp_checksum_complete(skb))
> +	/* Assumes header and options unchanged since checksum_init() */
> +	if (tcp_checksum_complete(skb))
>  		goto csum_err;
>  

Not true.

The skb->len can be modified by the call to sk_filter() done
by tcp_v4_rcv().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html