netdev - Re: [PATCH] ipv6.h: reassembly: replace calculated magic number with multiplication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100216.233821.260093505.davem@davemloft.net>
Date:	Tue, 16 Feb 2010 23:38:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	kaber@...sh.net, shanwei@...fujitsu.com, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [PATCH] ipv6.h: reassembly: replace calculated magic number
 with multiplication

From: Joe Perches <joe@...ches.com>
Date: Tue, 16 Feb 2010 20:40:04 -0800

> On Tue, 2010-02-16 at 16:47 +0100, Patrick McHardy wrote:
>> Joe Perches wrote:
>> >> @@ -246,6 +246,8 @@ extern int ipv6_opt_accepted(struct sock *sk, struct sk_buff *skb);
>> >>  int ip6_frag_nqueues(struct net *net);
>> >>  int ip6_frag_mem(struct net *net);
>> >>  
>> >> +#define IPV6_FRAG_HIGH_THRESH	262144		/* == 256*1024 */
>> >> +#define IPV6_FRAG_LOW_THRESH	196608		/* == 192*1024 */
>> >>  #define IPV6_FRAG_TIMEOUT	(60*HZ)		/* 60 seconds */
>> > 
>> > 196608 isn't a number I want to remember.
>> > Is this better as:
>> > 
>> > #define IPV6_FRAG_HIGH_THRESH	(256 * 1024)	/* 262144 */
>> > #define IPV6_FRAG_LOW_THRESH	(192 * 1024)	/* 196608 */
>> 
>> Please send a patch, I'll apply it once these patches are in Dave's
>> tree.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html