netdev - Re: [PATCH] atm : fix /sys/devices/virtual/atm/X/carrier(ATM_PHY_SIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100217113529.GA18818@frolo.macqel>
Date:	Wed, 17 Feb 2010 12:35:29 +0100
From:	Philippe De Muyter <phdm@...qel.be>
To:	David Miller <davem@...emloft.net>
Cc:	chas3@...rs.sourceforge.net, chas@....nrl.navy.mil,
	netdev@...r.kernel.org
Subject: Re: [PATCH] atm : fix
	/sys/devices/virtual/atm/X/carrier(ATM_PHY_SIG_UNKNOWN)

Hi Chas, David,

On Tue, Feb 16, 2010 at 10:16:51PM -0800, David Miller wrote:
> From: "Chas Williams (CONTRACTOR)" <chas@....nrl.navy.mil>
> Date: Sun, 14 Feb 2010 16:34:40 -0500
> 
> > as i said before there is carrier or there is not.  if the driver
> > doesnt support checking/knowing the carrier status it should simply
> > say 'yes i have carrier'.
> 
> I agree %100 and this is how we handle similar situations
> for other networking device types.

I also agree 100% with that : the low-level driver must do that, not the
generic class driver.  Here cxacru is punished because other atm drivers
forget to set signal = ATM_PHY_SIG_FOUND.

Philippe
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html