netdev - [PATCH] drivers/net/wireless/p54/txrx.c Fix off by one error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1266410415.17837.6.camel@ICE-BOX>
Date:	Wed, 17 Feb 2010 23:40:15 +1100
From:	Darren Jenkins <darrenrjenkins@...il.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	Michael Wu <flamingice@...rmilk.net>,
	Christian Lamparter <chunkeey@....de>,
	Larry Finger <Larry.Finger@...inger.net>,
	Bob Copeland <me@...copeland.com>,
	"Luis R. Rodriguez" <lrodriguez@...eros.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	Kernel Janitors <kernel-janitors@...r.kernel.org>
Subject: [PATCH] drivers/net/wireless/p54/txrx.c Fix off by one error

fix off by one error in the queue size check of p54_tx_qos_accounting_alloc()

Coverity CID: 13314

Signed-off-by: Darren Jenkins <darrenrjenkins@...il.com>
---
 drivers/net/wireless/p54/txrx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/p54/txrx.c b/drivers/net/wireless/p54/txrx.c
index b6dda2b..9d147de 100644
--- a/drivers/net/wireless/p54/txrx.c
+++ b/drivers/net/wireless/p54/txrx.c
@@ -186,7 +186,7 @@ static int p54_tx_qos_accounting_alloc(struct p54_common *priv,
 	struct ieee80211_tx_queue_stats *queue;
 	unsigned long flags;
 
-	if (WARN_ON(p54_queue > P54_QUEUE_NUM))
+	if (WARN_ON(p54_queue >= P54_QUEUE_NUM))
 		return -EINVAL;
 
 	queue = &priv->tx_stats[p54_queue];
-- 
1.6.3.3



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html