netdev - Re: [net-next PATCH v4 2/3] net: TCP thin linear timeouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100217.163255.133898079.davem@davemloft.net>
Date:	Wed, 17 Feb 2010 16:32:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	apetlund@...ula.no
Cc:	netdev@...r.kernel.org, ilpo.jarvinen@...sinki.fi,
	eric.dumazet@...il.com, hannemann@...s.rwth-aachen.de,
	linux-kernel@...r.kernel.org, shemminger@...tta.com,
	william.allen.simpson@...il.com, damian@....rwth-aachen.de,
	ebiederm@...ssion.com
Subject: Re: [net-next PATCH v4 2/3] net: TCP thin linear timeouts

From: Andreas Petlund <apetlund@...ula.no>
Date: Tue, 16 Feb 2010 15:40:41 +0100

> @@ -341,6 +342,8 @@ struct tcp_sock {
>  	u16	advmss;		/* Advertised MSS			*/
>  	u8	frto_counter;	/* Number of new acks after RTO */
>  	u8	nonagle;	/* Disable Nagle algorithm?             */
> +	u8      thin_lto    : 1,/* Use linear timeouts for thin streams */
> +		thin_undef  : 7;
>  

There is now a gap of 3 unused bytes here in this critical
core TCP socket data structure.

Please either find a way to avoid this hole, or document
it with a comment.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html